Code review comment for lp:~axlrose112/midori/midori-restful_client-feature

Revision history for this message
Cris Dywan (kalikiana) wrote :

As an observation the coding style diverts a bit and uses Java style VariableNames rather than variableNames, though as always I consider this up to the extension author(s). The code is generally very clean and modular, which is nice.

Suggestions for improvement:

You could use Midori.Database API to simplify error handling and binding of parameters. Compiled statements are more efficient than concatenating queries on demand.
c.f. grep Midori.Database extensions

I didn't figure out how to create projects. I think the UX needs improvement.

A "Submit" button would seem like a nice idea, through trial and error I found out that hitting Enter in the text field makes a request, but it took me a moment.

^^ I think the projects UX is critical here for landing a first version, the other ones are optional.

review: Needs Fixing

« Back to merge proposal