Merge ~axino/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:axino into ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master

Proposed by Junien F
Status: Merged
Approved by: Laurent Sesquès
Approved revision: e486fda773cbc5ccd092b6c80e1b70f812a09bb0
Merged at revision: 5ccd02bcd8506f90659fd813711a811b64e33916
Proposed branch: ~axino/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:axino
Merge into: ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master
Diff against target: 48 lines (+12/-3)
2 files modified
hooks/relations/keystone-credentials/requires.py (+2/-2)
reactive/openstack_exporter.py (+10/-1)
Reviewer Review Type Date Requested Status
Laurent Sesquès Approve
Review via email: mp+343611@code.launchpad.net

Commit message

handle keystone v3 with keystone relation data

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Laurent Sesquès (sajoupa) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 5ccd02bcd8506f90659fd813711a811b64e33916

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/hooks/relations/keystone-credentials/requires.py b/hooks/relations/keystone-credentials/requires.py
index 4cd17eb..4c5ef74 100644
--- a/hooks/relations/keystone-credentials/requires.py
+++ b/hooks/relations/keystone-credentials/requires.py
@@ -26,7 +26,7 @@ class KeystoneCredentialsRequires(RelationBase):
26 'api_version', 'auth_host', 'auth_port', 'auth_protocol',26 'api_version', 'auth_host', 'auth_port', 'auth_protocol',
27 'credentials_host', 'credentials_password', 'credentials_port',27 'credentials_host', 'credentials_password', 'credentials_port',
28 'credentials_project', 'credentials_project_id',28 'credentials_project', 'credentials_project_id',
29 'credentials_protocol', 'credentials_username', 'region'29 'credentials_protocol', 'credentials_username', 'domain', 'region'
30 ]30 ]
3131
32 def update_state(self):32 def update_state(self):
@@ -67,7 +67,7 @@ class KeystoneCredentialsRequires(RelationBase):
67 def auth_url(self):67 def auth_url(self):
68 auth_url_format_api_v = {68 auth_url_format_api_v = {
69 "2": "{}://{}:{}/v2.0",69 "2": "{}://{}:{}/v2.0",
70 "3": "{}://{}:{}/3"70 "3": "{}://{}:{}/v3"
71 }71 }
72 version = self.api_version()72 version = self.api_version()
73 if version:73 if version:
diff --git a/reactive/openstack_exporter.py b/reactive/openstack_exporter.py
index eeeeacb..8df7c93 100644
--- a/reactive/openstack_exporter.py
+++ b/reactive/openstack_exporter.py
@@ -143,6 +143,16 @@ def get_credentials():
143 else:143 else:
144 kv = unitdata.kv()144 kv = unitdata.kv()
145 creds = kv.get('keystone-relation-creds')145 creds = kv.get('keystone-relation-creds')
146 # The "dict" given by the relation and the variables expected by the
147 # template aren't the same, so we need to manually map some values.
148 if 'domain' in creds:
149 if 'credentials_user_domain_name' not in creds:
150 creds['credentials_user_domain_name'] = creds['domain']
151 if 'credentials_project_domain_name' not in creds:
152 creds['credentials_project_domain_name'] = creds['domain']
153 if 'api_version' in creds:
154 if 'identity_api_version' not in creds:
155 creds['credentials_identity_api_version'] = int(creds['api_version'])
146 ssl_ca = convert_from_base64(config.get('ssl_ca'))156 ssl_ca = convert_from_base64(config.get('ssl_ca'))
147 if ssl_ca:157 if ssl_ca:
148 creds['ssl_ca'] = ssl_ca158 creds['ssl_ca'] = ssl_ca
@@ -220,4 +230,3 @@ def update_nrpe_config(svc):
220 'check_http -I 127.0.0.1 -p {} -u /metrics'.format(port)230 'check_http -I 127.0.0.1 -p {} -u /metrics'.format(port)
221 )231 )
222 nrpe_setup.write()232 nrpe_setup.write()
223

Subscribers

People subscribed via source and target branches

to all changes: