Code review comment for lp:~awe/phablet-extras/ofono-socket-exit

Revision history for this message
Tony Espy (awe) wrote :

We've discussed this approach for over a week, and this is the first time I've heard your opposition to this approach.

With regards to the case where ofono is started, but it's expected that rild isn't available, I've stated in the past that the best approach to solving this is to not enable the device plugin ( plugins/ril ) in the first place. The standard technique that ofono uses is a udevng plugin, which wasn't used originally as we didn't run udev in our Ubuntyu container. The udev approach also isn't really the best approach to determining that a device runs rild.

So another approach would be to write a new plugin which understands how to query the Android properties and only enable the ril plugin based upon the values of one or more ril-specific properties.

I really would prefer not to put hard retry limits on the RILD socket in the code. Upstart has the ability to cap restarts over a given time period, which couldn't be leveraged if the retries are in the /gril layer.

« Back to merge proposal