Code review comment for lp:~awe/phablet-extras/ofono-raring

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Needed changes just to make it get to the failed point pointed above:
$ bzr diff
=== modified file 'Makefile.am'
--- Makefile.am 2013-03-28 12:50:26 +0000
+++ Makefile.am 2013-04-09 02:28:20 +0000
@@ -526,7 +526,7 @@
    src/cdma-sms.c src/private-network.c src/cdma-netreg.c \
    src/cdma-provision.c src/handsfree.c

-src_ofonod_LDADD = $(builtin_libadd) @GLIB_LIBS@ @DBUS_LIBS@ -ldl
+src_ofonod_LDADD = $(builtin_libadd) @GLIB_LIBS@ @DBUS_LIBS@ -ldl -lwaudio

 src_ofonod_LDFLAGS = -Wl,--export-dynamic \
     -Wl,--version-script=$(srcdir)/src/ofono.ver

=== modified file 'debian/control'
--- debian/control 2013-03-28 12:50:26 +0000
+++ debian/control 2013-04-09 02:14:30 +0000
@@ -6,10 +6,12 @@
 Uploaders: Jonny Lamb <email address hidden>, Hector Oron <email address hidden>, Konstantinos Margaritis <email address hidden>
 Build-Depends: debhelper (>= 7.0.50~),
                cdbs,
+ dh-autoreconf,
                libtool,
                libglib2.0-dev (>= 2.22),
                libdbus-glib-1-dev,
                libudev-dev,
+ libwaudio1-dev (>= 1.4~quantal1),
                udev,
                libbluetooth-dev (>= 4.30),
                mobile-broadband-provider-info

=== modified file 'debian/rules'
--- debian/rules 2012-08-22 19:59:08 +0000
+++ debian/rules 2013-04-09 02:05:25 +0000
@@ -2,6 +2,7 @@
 DEB_AUTO_CLEANUP_RCS := yes

 include /usr/share/cdbs/1/class/autotools.mk
+include /usr/share/cdbs/1/rules/autoreconf.mk
 include /usr/share/cdbs/1/rules/debhelper.mk
 #include /usr/share/cdbs/1/rules/simple-patchsys.mk
 include /usr/share/cdbs/1/rules/utils.mk

« Back to merge proposal