Mind removing extra space between '(' and 'ap_count'?
Also, would be nice to change the DBG message "Found %d APs" to also say we're just getting the first AP.
42 + if (i == 0)
43 + memcpy(*settings + i, ap,
44 + sizeof(struct ofono_gprs_provision_data));
Mind adding a comment in there before 'i == 0' explaining why we're only copying the first provisioning data? (small one, as you explained on a previous code block).
Would also be nice to remove the extra DGB for the other APNs, as it would confuse folks trying to debug a possible APN issue (you could remove the DBG lines and only get that for the one you copied over to 'settings').
30 + if ( ap_count > 1)
Mind removing extra space between '(' and 'ap_count'?
Also, would be nice to change the DBG message "Found %d APs" to also say we're just getting the first AP.
42 + if (i == 0) provision_ data));
43 + memcpy(*settings + i, ap,
44 + sizeof(struct ofono_gprs_
Mind adding a comment in there before 'i == 0' explaining why we're only copying the first provisioning data? (small one, as you explained on a previous code block).
Would also be nice to remove the extra DGB for the other APNs, as it would confuse folks trying to debug a possible APN issue (you could remove the DBG lines and only get that for the one you copied over to 'settings').