NetworkManager

Merge ~awe/network-manager/+git/ubuntu:fix-apparmor-denial into network-manager:snap-1.10

  1. Git
  2. lp:~awe/network-manager/+git/ubuntu
  3. fix-apparmor-denial
  4. Merge into snap-1.10
Proposed by Tony Espy
Status: Merged
Approved by: Tony Espy
Approved revision: d36d0db7f02a207ac86b249b7450ec572d767659
Merged at revision: d1bf7f18ddd8ec446b1f6c869468845c213c1039
Proposed branch: ~awe/network-manager/+git/ubuntu:fix-apparmor-denial
Merge into: network-manager:snap-1.10
Diff against target: 22 lines (+2/-2)
1 file modified
snap/snapcraft.yaml (+2/-2)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato (community) Approve
Review via email: mp+354421@code.launchpad.net

Description of the change

This change fixes Apparmor denials when NetworkManager tries to introspect devices on startup. This can cause NM to mis-classify some device types.

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 2d4bcb5..3ae06bd 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -11,7 +11,7 @@ description: |
6 VPN serivces.
7 Please find the source code at: https://code.launchpad.net/~network-manager/network-manager/+git/ubuntu/+ref/snap-1.10
8 base: core18
9-confinement: devmode
10+confinement: strict
11 grade: stable
12
13 slots:
14@@ -50,7 +50,7 @@ apps:
15 command: bin/networkmanager
16 daemon: simple
17 slots: [service]
18- plugs: [modem-manager, ppp, network-setup-observe, wpa, firewall-control]
19+ plugs: [modem-manager, ppp, network-setup-observe, wpa, firewall-control, hardware-observe]
20 parts:
21 hooks:
22 plugin: dump

Subscribers

People subscribed via source and target branches

to all changes: