Code review comment for lp:~avishai-ish-shalom/cloud-init/chef

Revision history for this message
Mike Moulton (mmoulton) wrote :

I seem to be unable to use the chef feature as included in the Oneiric Beta 1. I have noticed the following errors with this:

- If 'install_type' is undefined, the process fails

- 'firstboot.json' fails to write as it does not yet exist. Assume the missing 'w' param is needed.

- 'validation_cert' writes to '/etc/chef/validation.cert', however to the best of my knowledge chef-client does not know about this file. Instead, it's looking for '/etc/chef/validation.pem' as defined in the client.rb template.

- There seems to be a problem with 'subprocess.check_call([gem_bin', this failed for me, saying 'gem_bin' could not be found. Things work better if you do not install from gems.

I'm not familiar with how to submit patches via launchpad.net, otherwise I would have included fixes for these items.

I would love to get these items fixed for potential inclusion in Oneiric before it goes stable. Let me know what I can do to help.

review: Needs Fixing

« Back to merge proposal