Code review comment for lp:~avishai-ish-shalom/cloud-init/chef

A. it's an unrelated feature. being a git man i thought a branch can be
done in the local repo with bazzar, then i got lazy and just left the
first commit. i've since saw the error of my ways and will branch a
different repo in the future (unless you can tell me what's the bazzar
equivalent of feature branch is).

On 18/07/11 18:29, Scott Moser wrote:
> Review: Needs Information
> Avishai,
> Thank you very much for taking the time to put this together. I'd like to merge this for Oneiric.
>
> I have a couple comments
> a.) Why the change to cloudinit/CloudConfig/cc_set_hostname.py ?
> You summarized that as "Allow configurable hostname prefix and hostname attribute", but I don't initially see how its related to the rest of the commits. If its valuable, we can merge it, but I'd like that to be done separately if it is not related.
> b.) You added 'tools/write-mime-multipart.py'
> This file has been moved to cloud-utils (http://launchpad.net/cloud-utils) .
>
> Thanks again, I'm looking forward to hearing back from you. Sorry for the slow reply.
>