Code review comment for lp:~avishai-ish-shalom/cloud-init/chef

Revision history for this message
Scott Moser (smoser) wrote :

Avishai,
  Thank you very much for taking the time to put this together. I'd like to merge this for Oneiric.

  I have a couple comments
a.) Why the change to cloudinit/CloudConfig/cc_set_hostname.py ?
    You summarized that as "Allow configurable hostname prefix and hostname attribute", but I don't initially see how its related to the rest of the commits. If its valuable, we can merge it, but I'd like that to be done separately if it is not related.
b.) You added 'tools/write-mime-multipart.py'
   This file has been moved to cloud-utils (http://launchpad.net/cloud-utils) .

  Thanks again, I'm looking forward to hearing back from you. Sorry for the slow reply.

review: Needs Information

« Back to merge proposal