Merge lp:~autopilot/xpathselect/update-for-1.3 into lp:xpathselect

Proposed by Thomi Richards
Status: Merged
Approved by: Michael Terry
Approved revision: 38
Merged at revision: 32
Proposed branch: lp:~autopilot/xpathselect/update-for-1.3
Merge into: lp:xpathselect
Diff against target: 78 lines (+17/-3)
5 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+6/-0)
debian/control (+2/-2)
lib/node.h (+3/-0)
test/dummynode.h (+5/-0)
To merge this branch: bzr merge lp:~autopilot/xpathselect/update-for-1.3
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+159547@code.launchpad.net

Commit message

Update xpathselect with new API for 1.3 series.

Description of the change

Update of xpathselect for 1.3

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
38. By Christopher Lee

Update changelog

Revision history for this message
Michael Terry (mterry) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2013-02-11 19:49:18 +0000
+++ CMakeLists.txt 2013-04-18 23:14:25 +0000
@@ -6,7 +6,7 @@
66
7include (GNUInstallDirs)7include (GNUInstallDirs)
88
9set (VERSION 1.2)9set (VERSION 1.3)
1010
11if(CMAKE_BUILD_TYPE STREQUAL "coverage")11if(CMAKE_BUILD_TYPE STREQUAL "coverage")
12 message("Building for coverage")12 message("Building for coverage")
1313
=== modified file 'debian/changelog'
--- debian/changelog 2013-02-25 11:05:39 +0000
+++ debian/changelog 2013-04-18 23:14:25 +0000
@@ -1,3 +1,9 @@
1xpathselect (1.3) UNRELEASED; urgency=low
2
3 * Bump version number
4
5 -- Christopher Lee <chris.lee@canonical.com> Thu, 18 Apr 2013 14:08:13 +1200
6
1xpathselect (1.2~daily13.02.25-0ubuntu1) raring; urgency=low7xpathselect (1.2~daily13.02.25-0ubuntu1) raring; urgency=low
28
3 [ Thomi Richards ]9 [ Thomi Richards ]
410
=== modified file 'debian/control'
--- debian/control 2013-02-11 19:49:18 +0000
+++ debian/control 2013-04-18 23:14:25 +0000
@@ -20,14 +20,14 @@
20Section: libdevel20Section: libdevel
21Architecture: any21Architecture: any
22Depends: ${misc:Depends},22Depends: ${misc:Depends},
23 libxpathselect1.2 (= ${binary:Version}),23 libxpathselect1.3 (= ${binary:Version}),
24Description: Select objects in an object tree using XPath queries - development files24Description: Select objects in an object tree using XPath queries - development files
25 This library allows you to select arbitrary objects in an object tree using a25 This library allows you to select arbitrary objects in an object tree using a
26 small subset of the XPath specification.26 small subset of the XPath specification.
27 .27 .
28 This package contains development files for xpathselect.28 This package contains development files for xpathselect.
2929
30Package: libxpathselect1.230Package: libxpathselect1.3
31Section: libs31Section: libs
32Architecture: any32Architecture: any
33Multi-Arch: same33Multi-Arch: same
3434
=== renamed file 'debian/libxpathselect1.2.install' => 'debian/libxpathselect1.3.install'
=== modified file 'lib/node.h'
--- lib/node.h 2012-08-10 04:06:05 +0000
+++ lib/node.h 2013-04-18 23:14:25 +0000
@@ -34,6 +34,9 @@
34 /// Get the node's name.34 /// Get the node's name.
35 virtual std::string GetName() const =0;35 virtual std::string GetName() const =0;
3636
37 /// Get the node's full path
38 virtual std::string GetPath() const =0;
39
37 /// Return true if the node matches the property with the given name & value40 /// Return true if the node matches the property with the given name & value
38 ///\note: All property values are treated as strings. It is the implementors41 ///\note: All property values are treated as strings. It is the implementors
39 /// responsibility to convert the value to the appropriate type.42 /// responsibility to convert the value to the appropriate type.
4043
=== modified file 'test/dummynode.h'
--- test/dummynode.h 2012-08-10 04:06:05 +0000
+++ test/dummynode.h 2013-04-18 23:14:25 +0000
@@ -35,6 +35,11 @@
35 return name_;35 return name_;
36 }36 }
3737
38 std::string GetPath() const override
39 {
40 return std::string();
41 }
42
38 void SetName(std::string const& name)43 void SetName(std::string const& name)
39 {44 {
40 name_ = name;45 name_ = name;

Subscribers

People subscribed via source and target branches

to all changes: