Unity Settings Daemon

Code review comment for lp:~attente/unity-settings-daemon/gnome-key-grabber

  1. gnome-key-grabber
  2. Merge into trunk
Revision history for this message
William Hua (attente) wrote :

So, the code in that file originally used DESKTOP_SESSION. But if we use XDG_CURRENT_DESKTOP, then there is no way to differentiate between GNOME Shell, GNOME Classic, and the two GNOME Fallback sessions. These are the values for each DE:

[Desktop: DESKTOP_SESSION, XDG_CURRENT_DESKTOP]
GNOME Shell: gnome, GNOME
GNOME Classic: gnome-classic, GNOME
GNOME Flashback (Compiz): gnome-fallback-compiz, GNOME
GNOME Flashback (Metacity): gnome-fallback, GNOME
Unity: ubuntu, Unity

So the question is if GNOME Classic and GNOME Fallback should use the legacy key grabber. If yes, we should use DESKTOP_SESSION, if not, we can use XDG_CURRENT_DESKTOP.

« Back to merge proposal