Code review comment for lp:~attente/unity-gtk-module/gtk-enable-mnemonics

Revision history for this message
Allison Karlitskaya (desrt) wrote :

Just one more nag: this check will never fail:

+ if (gtk_enable_mnemonics_name == NULL)
282 + gtk_enable_mnemonics_name = g_intern_static_string ("gtk-enable-mnemonics");
283 +
284 + if (g_param_spec_get_name (pspec) == gtk_enable_mnemonics_name)
285 + {

because you already have a detailed signal connection.

« Back to merge proposal