is_blacklisted is only called once when the module is first loaded. I'm thinking it's probably better to unref the GSettings object as soon as it's done with it rather than keeping it around for the life of the process. If you still disagree though, I'll fix it.
But agreed on your other points, hopefully those are fixed now.
Thanks Charles!
is_blacklisted is only called once when the module is first loaded. I'm thinking it's probably better to unref the GSettings object as soon as it's done with it rather than keeping it around for the life of the process. If you still disagree though, I'll fix it.
But agreed on your other points, hopefully those are fixed now.