Code review comment for lp:~attente/ubuntu-ui-toolkit/1263163

Revision history for this message
Cris Dywan (kalikiana) wrote :

The blindfold has just fallen off… William, you're right. It makes sense to set LANGUAGE. The whole time I was focussed on finding a problem with re-loading and updating components when simply the old ones were loaded again.

Could you replace the bug reference in the comment with an explicit reasoning? Something like this:

/*
 LANGUAGE may be set to one one or more languages for example "fi" or "sv:de".
 Override it here so that setlocale won't stick to the old locale.
*/

And please do a 'bzr merge --pull lp:ubuntu-ui-toolkit' for good measure, then I think we're good.

« Back to merge proposal