Merge lp:~attente/ubuntu-system-settings/1263163 into lp:ubuntu-system-settings

Proposed by William Hua
Status: Merged
Approved by: Iain Lane
Approved revision: 553
Merged at revision: 569
Proposed branch: lp:~attente/ubuntu-system-settings/1263163
Merge into: lp:ubuntu-system-settings
Diff against target: 23 lines (+1/-1)
2 files modified
plugins/language/DisplayLanguage.qml (+1/-0)
plugins/language/SubsetView.qml (+0/-1)
To merge this branch: bzr merge lp:~attente/ubuntu-system-settings/1263163
Reviewer Review Type Date Requested Status
Iain Lane Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+201048@code.launchpad.net

Commit message

[language] Disable confirm if unchanged.

Description of the change

[language] Disable confirm if unchanged.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

Looks neat, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/language/DisplayLanguage.qml'
--- plugins/language/DisplayLanguage.qml 2013-10-11 06:03:15 +0000
+++ plugins/language/DisplayLanguage.qml 2014-01-09 17:23:55 +0000
@@ -109,6 +109,7 @@
109 id: confirmButton109 id: confirmButton
110110
111 text: i18n.tr("Confirm")111 text: i18n.tr("Confirm")
112 enabled: languageList.currentIndex != plugin.currentLanguage
112113
113 anchors.left: parent.horizontalCenter114 anchors.left: parent.horizontalCenter
114 anchors.right: parent.right115 anchors.right: parent.right
115116
=== modified file 'plugins/language/SubsetView.qml'
--- plugins/language/SubsetView.qml 2013-10-01 10:19:17 +0000
+++ plugins/language/SubsetView.qml 2014-01-09 17:23:55 +0000
@@ -57,7 +57,6 @@
57 }57 }
58 }58 }
59 enabled: model.enabled59 enabled: model.enabled
60
61 }60 }
6261
63 add: Transition {62 add: Transition {

Subscribers

People subscribed via source and target branches