Merge lp:~attente/ubuntu-system-settings/1263163 into lp:ubuntu-system-settings

Proposed by William Hua
Status: Merged
Approved by: Iain Lane
Approved revision: 553
Merged at revision: 569
Proposed branch: lp:~attente/ubuntu-system-settings/1263163
Merge into: lp:ubuntu-system-settings
Diff against target: 23 lines (+1/-1)
2 files modified
plugins/language/DisplayLanguage.qml (+1/-0)
plugins/language/SubsetView.qml (+0/-1)
To merge this branch: bzr merge lp:~attente/ubuntu-system-settings/1263163
Reviewer Review Type Date Requested Status
Iain Lane Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+201048@code.launchpad.net

Commit message

[language] Disable confirm if unchanged.

Description of the change

[language] Disable confirm if unchanged.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

Looks neat, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/language/DisplayLanguage.qml'
2--- plugins/language/DisplayLanguage.qml 2013-10-11 06:03:15 +0000
3+++ plugins/language/DisplayLanguage.qml 2014-01-09 17:23:55 +0000
4@@ -109,6 +109,7 @@
5 id: confirmButton
6
7 text: i18n.tr("Confirm")
8+ enabled: languageList.currentIndex != plugin.currentLanguage
9
10 anchors.left: parent.horizontalCenter
11 anchors.right: parent.right
12
13=== modified file 'plugins/language/SubsetView.qml'
14--- plugins/language/SubsetView.qml 2013-10-01 10:19:17 +0000
15+++ plugins/language/SubsetView.qml 2014-01-09 17:23:55 +0000
16@@ -57,7 +57,6 @@
17 }
18 }
19 enabled: model.enabled
20-
21 }
22
23 add: Transition {

Subscribers

People subscribed via source and target branches