Mir

Code review comment for lp:~attente/mir/basic-menu-surface-position

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I think this approach is doomed - DefaultPlacementStrategy only affects the initial placement of the window and, while abusing the depth does put the menu on top of the parent it also puts it on top of other surfaces too (even ones have focus).

To be effective there needs to be more "plumbing" in the window management to handle

It ignores client preferences as to where to locate the menu WRT to placement rectangle boundaries and allows both the parent and the menu to be moved independently.

review: Disapprove

« Back to merge proposal