1. Doesn't compile - see below
2. Is wrong - the placement should be relative to the parent window
[ 34%] Building CXX object src/server/shell/CMakeFiles/mirshell.dir/default_placement_strategy.cpp.o
/mir/src/server/shell/default_placement_strategy.cpp: In member function 'virtual mir::scene::SurfaceCreationParameters mir::shell::DefaultPlacementStrategy::place(const mir::scene::Session&, const mir::scene::SurfaceCreationParameters&)':
/mir/src/server/shell/default_placement_strategy.cpp:46:27: error: 'struct mir::scene::SurfaceCreationParameters' has no member named 'attachment_rect'
if (placed_parameters.attachment_rect.is_set()) ^
/mir/src/server/shell/default_placement_strategy.cpp:47:54: error: 'struct mir::scene::SurfaceCreationParameters' has no member named 'attachment_rect' placed_parameters.top_left = placed_parameters.attachment_rect.value().bottom_left(); ^
src/server/shell/CMakeFiles/mirshell.dir/build.make:54: recipe for target 'src/server/shell/CMakeFiles/mirshell.dir/default_placement_strategy.cpp.o' failed
make[2]: *** [src/server/shell/CMakeFiles/mirshell.dir/default_placement_strategy.cpp.o] Error 1
CMakeFiles/Makefile2:3151: recipe for target 'src/server/shell/CMakeFiles/mirshell.dir/all' failed
1. Doesn't compile - see below
2. Is wrong - the placement should be relative to the parent window
[ 34%] Building CXX object src/server/ shell/CMakeFile s/mirshell. dir/default_ placement_ strategy. cpp.o server/ shell/default_ placement_ strategy. cpp: In member function 'virtual mir::scene: :SurfaceCreatio nParameters mir::shell: :DefaultPlaceme ntStrategy: :place( const mir::scene: :Session& , const mir::scene: :SurfaceCreatio nParameters& )': server/ shell/default_ placement_ strategy. cpp:46: 27: error: 'struct mir::scene: :SurfaceCreatio nParameters' has no member named 'attachment_rect' parameters. attachment_ rect.is_ set())
^ server/ shell/default_ placement_ strategy. cpp:47: 54: error: 'struct mir::scene: :SurfaceCreatio nParameters' has no member named 'attachment_rect'
placed_ parameters. top_left = placed_ parameters. attachment_ rect.value( ).bottom_ left();
^ shell/CMakeFile s/mirshell. dir/build. make:54: recipe for target 'src/server/ shell/CMakeFile s/mirshell. dir/default_ placement_ strategy. cpp.o' failed shell/CMakeFile s/mirshell. dir/default_ placement_ strategy. cpp.o] Error 1 Makefile2: 3151: recipe for target 'src/server/ shell/CMakeFile s/mirshell. dir/all' failed
/mir/src/
/mir/src/
if (placed_
/mir/src/
src/server/
make[2]: *** [src/server/
CMakeFiles/