Merge lp:~attente/gtk/1434094 into lp:~ubuntu-desktop/gtk/ubuntugtk3

Proposed by William Hua
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 495
Merged at revision: 495
Proposed branch: lp:~attente/gtk/1434094
Merge into: lp:~ubuntu-desktop/gtk/ubuntugtk3
Diff against target: 61 lines (+41/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/git-x11-don-t-apply-scaling-factor-twice.patch (+32/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~attente/gtk/1434094
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+285092@code.launchpad.net

Commit message

Take upstream patch fixing the calculation of the monitor work area when a different window scaling factor is used.

Description of the change

Take upstream patch fixing the calculation of the monitor work area when a different window scaling factor is used.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

upstream said that they like it, why wouldn't we? ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2016-02-03 16:08:11 +0000
+++ debian/changelog 2016-02-04 16:42:03 +0000
@@ -1,3 +1,11 @@
1gtk+3.0 (3.18.7-1ubuntu2) UNRELEASED; urgency=medium
2
3 * debian/patches/git-x11-don-t-apply-scaling-factor-twice.patch:
4 + Take upstream patch to fix calculation of monitor work area when
5 a non-unity scale factor is used (LP: #1434094)
6
7 -- William Hua <william.hua@canonical.com> Thu, 04 Feb 2016 11:10:21 -0500
8
1gtk+3.0 (3.18.7-1ubuntu1) xenial; urgency=medium9gtk+3.0 (3.18.7-1ubuntu1) xenial; urgency=medium
210
3 * New upstream version merged from Debian11 * New upstream version merged from Debian
412
=== added file 'debian/patches/git-x11-don-t-apply-scaling-factor-twice.patch'
--- debian/patches/git-x11-don-t-apply-scaling-factor-twice.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/git-x11-don-t-apply-scaling-factor-twice.patch 2016-02-04 16:42:03 +0000
@@ -0,0 +1,32 @@
1From fd6f15aad530f8244301fd43acbd23cde920f9b1 Mon Sep 17 00:00:00 2001
2From: William Hua <william.hua@canonical.com>
3Date: Tue, 2 Feb 2016 15:33:33 -0500
4Subject: [PATCH] x11: don't apply scaling factor twice
5
6The fallback behaviour of get_work_area () divides the
7screen width and height by the window scaling factor, but
8those values are already scaled down.
9
10https://bugzilla.gnome.org/show_bug.cgi?id=761474
11---
12 gdk/x11/gdkscreen-x11.c | 4 ++--
13 1 file changed, 2 insertions(+), 2 deletions(-)
14
15diff --git a/gdk/x11/gdkscreen-x11.c b/gdk/x11/gdkscreen-x11.c
16index 44bb69f..abd3cae 100644
17--- a/gdk/x11/gdkscreen-x11.c
18+++ b/gdk/x11/gdkscreen-x11.c
19@@ -328,8 +328,8 @@ get_work_area (GdkScreen *screen,
20 /* Defaults in case of error */
21 area->x = 0;
22 area->y = 0;
23- area->width = gdk_screen_get_width (screen) / x11_screen->window_scale;
24- area->height = gdk_screen_get_height (screen) / x11_screen->window_scale;
25+ area->width = gdk_screen_get_width (screen);
26+ area->height = gdk_screen_get_height (screen);
27
28 if (!gdk_x11_screen_supports_net_wm_hint (screen,
29 gdk_atom_intern_static_string ("_NET_WORKAREA")))
30--
312.7.0
32
033
=== modified file 'debian/patches/series'
--- debian/patches/series 2016-02-03 16:05:28 +0000
+++ debian/patches/series 2016-02-04 16:42:03 +0000
@@ -25,3 +25,4 @@
25git-refresh-mir-backend.patch25git-refresh-mir-backend.patch
260001-gtkwindow-set-transparent-background-color.patch260001-gtkwindow-set-transparent-background-color.patch
27ubuntu_fileselector_behaviour.patch27ubuntu_fileselector_behaviour.patch
28git-x11-don-t-apply-scaling-factor-twice.patch

Subscribers

People subscribed via source and target branches

to all changes: