(there seems to be some noise/patch refresh in that revision, the important part is to have different .desktop for unity and GNOME so they can have different names)
Otherwise it looks good to merge in, settings as "needs fixing" until the different .desktop for GNOME and Unity item is done. We can deal with the warning in another bug/merge request if you want
Thanks for the work, some comments:
* Why did you change the git_drop_ ibus_engine_ whitelist. patch (is that still what is in git?)
* with that version, I get those warnings when clicking on "keyboard layout"
"Gtk-WARNING **: Unknown object user_input_source specified in sizegroup system- input-source- sizegroup"
those as well (but that was also happening with the previous version):
g_settings_ bind_with_ mapping: assertion 'G_IS_OBJECT (object)' failed
* it's my fault for not pointing that before/pointing the wrong patch, but could you include those changes to the .desktop: bazaar. launchpad. net/~ubuntu- desktop/ gnome-control- center/ ubuntu/ revision/ 522
http://
(there seems to be some noise/patch refresh in that revision, the important part is to have different .desktop for unity and GNOME so they can have different names)
Otherwise it looks good to merge in, settings as "needs fixing" until the different .desktop for GNOME and Unity item is done. We can deal with the warning in another bug/merge request if you want