Code review comment for ~athos-ribeiro/ubuntu/+source/samba:merge-2%4.13.5+dfsg-2-impish

* Changelog:
  - [√] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [√] no further upstream version to consider
     + Upstream has some release ahead of Debian but we should not diverge.
  - [√] debian changes look safe

* Old Delta:
  - [√] dropped changes are ok to be dropped
  - [√] nothing else to drop
  - [-] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [-] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
  - [√] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

Thanks for the MP Athos, LGTM.

If I were you I would avoid to add " * Drop change:" in all commit messages dropping changes, just the first one, with that git-ubuntu can generate the changelog for you in the right format (and avoiding an extra commit just fixing those things). Related to this I would remove " * Added changes:" from Sergio's commit, the first time I saw I thought you were adding this change :)

 172961d... by Sergio Durigan Junior on 2021-01-13

      * Added changes:
        - d/t/{cifs-share-access-uring,smbclient-share-access-uring}:
          Skip running the tests if on i386 platform, because the uring
          package is not available there.

I've been picky here but the commit messages in the right format can help a lot in the next merge, avoiding manual changes. However, this is not a big deal, I am approving this MP. Let me know when you want me to sponsor this upload for you.