Code review comment for ~athos-ribeiro/ubuntu/+source/php8.1:merge-lp1978364-kinetic

LGTM, +1

It looks like it builds fine in the PPA. I attempted to build locally in an LXC container but it hit a CPU spin in one of the test cases and eventually tripped the OOM killer:

    ...
    PASS gmp_setbit() basic tests [ext/gmp/tests/gmp_setbit.phpt]
    TEST 6423/15617 [ext/gmp/tests/gmp_setbit_long.php1]
    Error: websocket: close 1006 (abnormal closure): unexpected EOF

When my system came back, top was showing CPU usage up over 600! OOM killer did its job:

    [3615086.331225] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=lxc.payload.triage-kinetic,mems_allowed=0,global_oom,task_memcg=/user.slice/user-1000.slice/session-c2.scope,task=steamwebhelper,pid=859039,uid=1000
    [3615086.331260] Out of memory: Killed process 859039 (steamwebhelper) total-vm:612740kB, anon-rss:60872kB, file-rss:0kB, shmem-rss:12956kB, UID:1000 pgtables:816kB oom_score_adj:200
    [3615086.334708] oom_reaper: reaped process 859039 (steamwebhelper), now anon-rss:0kB, file-rss:0kB, shmem-rss:12952kB

I've built php many times and haven't seen a behavior like this. So I wouldn't rule it out as a fluke, esp. since the PPA seems to have built fine. But can you do a local build and autopkgtest run in an LXC container and see if anything similar happens for you? If it does, maybe file a bug report and/or disable the test.

I also triggered autopkgtests to run on launchpad and those look fine at least:

Results from https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-athos-ribeiro-lp1978364-merge-php-kinetic/?format=plain:
  php8.1 @ amd64:
    13.06.22 22:28:46 Log 🗒️ ✅ Triggers: ['php8.1/8.1.5-1ubuntu1~ppa1']
      cli PASS ✅
      cgi PASS ✅
      mod-php PASS ✅
      fpm PASS ✅
  php8.1 @ armhf:
    13.06.22 22:38:08 Log 🗒️ ✅ Triggers: ['php8.1/8.1.5-1ubuntu1~ppa1']
      cli PASS ✅
      cgi PASS ✅
      mod-php PASS ✅
      fpm PASS ✅
  php8.1 @ ppc64el:
    13.06.22 22:31:21 Log 🗒️ ✅ Triggers: ['php8.1/8.1.5-1ubuntu1~ppa1']
      cli PASS ✅
      cgi PASS ✅
      mod-php PASS ✅
      fpm PASS ✅
  php8.1 @ s390x:
    13.06.22 22:30:09 Log 🗒️ ✅ Triggers: ['php8.1/8.1.5-1ubuntu1~ppa1']
      cli PASS ✅
      cgi PASS ✅
      mod-php PASS ✅
      fpm PASS ✅
Running:
    time pkg release arch ppa trigger
    0:24:32 php8.1 kinetic arm64 athos-ribeiro/lp1978364-merge-php-kinetic php8.1/8.1.5-1ubuntu1~ppa1
Waiting:

The merge itself looks fine, and I agree with the drops. The remaining delta looks like it was brought forward correctly, and the git history is clean. The new patch makes sense, and matches the upstream patch but with the additional DEP3 info.