Ubuntu
nut package

Code review comment for ~athos-ribeiro/ubuntu/+source/nut:merge-lp1993425-lunar

  1. Git
  2. lp:~athos-ribeiro/ubuntu/+source/nut
  3. merge-lp1993425-lunar
  4. Merge into debian/sid
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Athos.

I see that this new release actually introduces a new binary package (libnutclient2), and drops libnutclient0. I was wondering if there could be any reverse dependencies affected by this (since we're talking about changes in the ABI/API), but apparently there's nothing that depends on libnutclient0:

$ reverse-depends -r lunar libnutclient0
Reverse-Depends
* libnutclient-dev
$ reverse-depends -r lunar -b libnutclient-dev
No reverse dependencies found

So we should be good with the transition.

As for the .symbols file being dropped, I understand the Debian maintainer's rationale here (indeed, maintaining C++ .symbols files is a pain), but I'm left wondering if this could cause any unwanted side effects. I don't think so, and as far as I have researched it should be OK to do what he's done, but it's a good idea to keep an eye on the package.

Either way, I'm +1 on making the package a sync. LGTM.

review: Approve

« Back to merge proposal