Code review comment for ~athos-ribeiro/ubuntu/+source/mdevctl:merge-mdevctl-rust-kinetic

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

On Tue, Jun 28, 2022 at 6:24 PM Athos Ribeiro
<email address hidden> wrote:
>
> MP updated to ship the cargo lockfile, as proposed in https://github.com/cpaelzer/ubuntu-mir/pull/3.

Nice, that looks cleaner than I thought, so you generate it right out
of the real vendor source that we added.
Awesome!

> PPA available at https://launchpad.net/~athos-ribeiro/+archive/ubuntu/mdevctl-vendored-plus-lockfile/+packages

Downloaded and checked, LGTM!
It is auto-compressed though since it is in the doc path - that is
fine but whatever checkers security had in mind need to be able to
deal with it.

Thanks, overall I think with that PPA we can go to security and MIR
team and ask if this can be approved as sufficient until the dh_cargo
tooling exists.

« Back to merge proposal