Ubuntu
isc-dhcp package

Code review comment for ~athos-ribeiro/ubuntu/+source/isc-dhcp:keama

  1. Git
  2. lp:~athos-ribeiro/ubuntu/+source/isc-dhcp
  3. keama
  4. Merge into ubuntu/devel
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Athos.

It looks great. The package builds fine, and I verified that the new binary is correctly installed under /usr/sbin. I was going to ask if it's really necessary to install it under sbin, but I guess it doesn't hurt to keep it this way.

I tried to enable testing by executing "dh_auto_test -- -C keama", but it didn't work because apparently there's no Makefile target for it. I wonder if upstream intends to implement this.

I'm leaving some minor suggestions below, but otherwise I'm approving the MP. Thanks.

review: Approve

« Back to merge proposal