Code review comment for ~athos-ribeiro/ubuntu/+source/apache2:postinst-triggered-mm

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Sergio.

It would be worth discussing this with with the SRU team (after an upload?). I'd be OK with waitin ga bit longer to see if we get any feedback from Debian on this.

> I'm specifically worried about the "behaviour change" side of this fix.

AFAICT, PHP should be the only package affected. If the concern is about "we are adding a feature to a stable release", I do believe that on the PHP end this should be considered a bug (which has been there for a long while) instead. However, this may indeed be seen as a feature in the apache2 side.

That said, an alternative approach could be:

- keep the noble change, adding support for triggers in apache2.
- change the php's libapache2-mod-php postinst script to reload or restart apache2 without the apache2-maintscript-helper.

Still, given that (most likely) the only known behavioral change is in php, the approach presented here could still be acceptable, although the alternative presented above looks safer from a SRU perspective.

Thoughts?

« Back to merge proposal