Ubuntu Docker Images

Code review comment for ~athos-ribeiro/ubuntu-docker-images/+git/squid:5.2-22.04-nofile-fix

  1. Git
  2. lp:~athos-ribeiro/ubuntu-docker-images/+git/squid
  3. 5.2-22.04-nofile-fix
  4. Merge into 5.2-22.04
Revision history for this message
Wen-Ding Zeng (wdzeng) wrote (last edit ):

Hi,

I noticed that there is a missing '#' to comment the message in Athos's [fix](https://git.launchpad.net/~athos-ribeiro/ubuntu-docker-images/+git/squid/commit?id=f12bcf7688f3045a04e3439cc9fa805c9fa809e6), which made squid failed to parse the config. After commenting out the message, the program ran like a charm on Fedora host in docker container. [Here](https://code.launchpad.net/~wdzeng/ubuntu-docker-images/+git/squid/+ref/5.2-22.04-nofile-fix) is a fix for that.

Lacking experiences of contributing to open sourced projects, I am not sure if it is polite to open another MR, or should ask Athos to merge my fix into his branch. Sorry for that.

In addition, the bug #1978272 affects branches `4.13-21.10`, `4.13-21.04` and `4.10-20.04` as well. I have examined that the fix worked in those branches. After this MR is merged, the fix should be cherry-picked to those branches.

Thank you very much!

« Back to merge proposal