Code review comment for ~athos-ribeiro/ubuntu-docker-images/+git/kafka:add-entrypoint

> to create a new zookeeper image would be to maintain a new Dockerfile with all the contents of the kafka

Good point. Not ideal, but it might be a solution indeed. From a UX perspective at least, it would be a great improvement. (and it opens the door for building more specific images in the future, only including the necessary binaries.) I’m leaving the implementation details up to you. In [1], I forked a step before, resulting in a common unnamed base and two different images for Zookeeper and Kafka.

[1] https://git.launchpad.net/~valentinviennot/ubuntu-docker-images/+git/kafka/tree/Dockerfile?h=split-images

> On 20 Apr 2022, at 15:55, Athos Ribeiro <email address hidden> wrote:
>
> Thanks, Valentin!
>
> AFAICT, LP does not support building to targets.
>
> One option to create a new zookeeper image would be to maintain a new Dockerfile with all the contents of the kafka one plus the additional stage you proposed (or even letting them differ a bit on entrypoints, exposed ports, etc. At first I considered layering the zookeeper image on top of the kafka one, but that would imply a new build chain order which our tooling is not yet ready to support.
>
> With this, we would maintain a Dockerfile.kafka and a Dockerfile.zookeeper in this repository (LP does support specifying which Dockerfile to use). Would that be any better than the current state?
> --
> https://code.launchpad.net/~athos-ribeiro/ubuntu-docker-images/+git/kafka/+merge/419704
> You are reviewing the proposed merge of ~athos-ribeiro/ubuntu-docker-images/+git/kafka:add-entrypoint into ~canonical-server/ubuntu-docker-images/+git/kafka:3.1-22.04.
>