Code review comment for ~athos-ribeiro/ubuntu-docker-images/+git/kafka:add-entrypoint

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Valentin!

AFAICT, LP does not support building to targets.

One option to create a new zookeeper image would be to maintain a new Dockerfile with all the contents of the kafka one plus the additional stage you proposed (or even letting them differ a bit on entrypoints, exposed ports, etc. At first I considered layering the zookeeper image on top of the kafka one, but that would imply a new build chain order which our tooling is not yet ready to support.

With this, we would maintain a Dockerfile.kafka and a Dockerfile.zookeeper in this repository (LP does support specifying which Dockerfile to use). Would that be any better than the current state?

« Back to merge proposal