Merge lp:~atcurtis/maria/5.5-dfly into lp:maria/5.5

Proposed by Antony T Curtis
Status: Work in progress
Proposed branch: lp:~atcurtis/maria/5.5-dfly
Merge into: lp:maria/5.5
Diff against target: 34 lines (+3/-3)
2 files modified
BUILD/check-cpu (+1/-1)
sql/threadpool_unix.cc (+2/-2)
To merge this branch: bzr merge lp:~atcurtis/maria/5.5-dfly
Reviewer Review Type Date Requested Status
Sergei Golubchik Needs Fixing
Review via email: mp+119680@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sergei Golubchik (sergii) wrote :

Did you check other places with #ifdef __FreeBSD__ ?
I've grepped for "freebsd" and here're few questions:

is cmake/os/FreeBSD.cmake used in your builds? Should it be?

dtrace.cmake might enable dtrace because the system name is not "freebsd". Is that correct?

I presume, system libedit is always available, is that right? If no - should freebsd-specific places in the bundled readline be extended?

yassl has bsd-specific code in one file

libmysql/CMakeLists.txt checks for "freebsd or apple" when making its compatibility workaround

./mysys/my_fopen.c
./mysys/my_gethwaddr.c
./sql/mysqld.cc

these files have bsd-specific code too, they might need changes.

review: Needs Fixing

Unmerged revisions

3493. By Antony T Curtis

Simple change to permit building on DragonFlyBSD

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'BUILD/check-cpu'
2--- BUILD/check-cpu 2012-01-13 14:50:02 +0000
3+++ BUILD/check-cpu 2012-08-15 07:24:23 +0000
4@@ -134,7 +134,7 @@
5 # Fallback when there is no /proc/cpuinfo
6 CPUINFO=" "
7 case "`uname -s`" in
8- FreeBSD|OpenBSD)
9+ FreeBSD|OpenBSD|DragonFly)
10 cpu_family=`uname -m`;
11 model_name=`sysctl -n hw.model`
12 ;;
13
14=== modified file 'sql/threadpool_unix.cc'
15--- sql/threadpool_unix.cc 2012-04-11 23:40:44 +0000
16+++ sql/threadpool_unix.cc 2012-08-15 07:24:23 +0000
17@@ -30,7 +30,7 @@
18 #include <sys/epoll.h>
19 typedef struct epoll_event native_event;
20 #endif
21-#if defined (__FreeBSD__) || defined (__APPLE__)
22+#if defined (__FreeBSD__) || defined (__APPLE__) || defined (__DragonFly__)
23 #include <sys/event.h>
24 typedef struct kevent native_event;
25 #endif
26@@ -286,7 +286,7 @@
27 return event->data.ptr;
28 }
29
30-#elif defined (__FreeBSD__) || defined (__APPLE__)
31+#elif defined (__FreeBSD__) || defined (__APPLE__) || defined (__DragonFly__)
32 int io_poll_create()
33 {
34 return kqueue();

Subscribers

People subscribed via source and target branches