Code review comment for lp:~asc/fluidity/testharnesscwd2

Revision history for this message
Patrick Farrell (pefarrell) wrote :

Hi Adam,

a) I'm a bit confused about what the use case of this can be. Can you tell the story of why you wanted this feature?

b) Couldn't this feature be much more simply implemented with a one-line change like

=== modified file 'tools/testharness.py'
--- tools/testharness.py 2011-08-05 11:19:06 +0000
+++ tools/testharness.py 2011-09-05 14:53:28 +0000
@@ -50,7 +50,7 @@
         for directory in testpaths:
           if os.path.exists(os.path.join(rootdir, directory)):
             dirnames.append(directory)
- testdirs = [ os.path.join( rootdir, x ) for x in dirnames ]
+ testdirs = [ os.path.join( rootdir, x ) for x in dirnames ] + [os.getcwd()]
         for directory in testdirs:
           subdirs = [ os.path.join(directory, x) for x in os.listdir(directory)]
           for subdir in subdirs:

? I don't really know why you didn't take this approach -- like I said, I don't know why you want it.

« Back to merge proposal