Code review comment for lp:~asanjar/charms/trusty/hadoop/hadoop-elk

Revision history for this message
Charles Butler (lazypower) wrote :

Amir,

I haven't run a deploy test yet. I've noted the one thing that stood out to me. A possible note here about interface names - since this just relates to elasticsearch and is not hyper specific to the E.lasticsearch L.ogstash K.ibana stack; it may make more sense to name the relationship appropriately, as this relationship would work with any data river associated with Elastic Search.

Otherwise, looks good so far. I'll run a deployment test once you've pushed the modifications.

review: Needs Fixing

« Back to merge proposal