Merge lp:~asac/lava-dispatcher/fastmodel-disablesuspend-should-wait-500sec into lp:lava-dispatcher

Proposed by Alexander Sack
Status: Rejected
Rejected by: Neil Williams
Proposed branch: lp:~asac/lava-dispatcher/fastmodel-disablesuspend-should-wait-500sec
Merge into: lp:lava-dispatcher
Diff against target: 14 lines (+2/-2)
1 file modified
lava_dispatcher/client/base.py (+2/-2)
To merge this branch: bzr merge lp:~asac/lava-dispatcher/fastmodel-disablesuspend-should-wait-500sec
Reviewer Review Type Date Requested Status
Andy Doan (community) Disapprove
Review via email: mp+119035@code.launchpad.net

Description of the change

500 seconds never failed here, while 240 always failed on fmhackbox in ec2

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

I have a branch that does this using a config variable. Will be merging it soon.

review: Disapprove
Revision history for this message
Andy Doan (doanac) wrote :
Revision history for this message
Alexander Sack (asac) wrote :

please request a merge on that one ... i want this fix by default in..

Revision history for this message
Alexander Sack (asac) wrote :

please use 500 for fastmodels. thanks.

Revision history for this message
Alexander Sack (asac) wrote :

> please use 500 for fastmodels. thanks.
besides from that the branch looks ok.

Unmerged revisions

367. By Alexander Sack

bump disablesuspend timeout to 500 seconds to allow hickups during fast model runs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lava_dispatcher/client/base.py'
--- lava_dispatcher/client/base.py 2012-08-02 23:05:53 +0000
+++ lava_dispatcher/client/base.py 2012-08-09 20:32:20 +0000
@@ -473,8 +473,8 @@
473 logging.info("Skip raising exception on the home screen has not displayed for health check jobs")473 logging.info("Skip raising exception on the home screen has not displayed for health check jobs")
474474
475 # we need to deal with the time the "input keyevent 82" takes475 # we need to deal with the time the "input keyevent 82" takes
476 # 240: for fastmodels, 120 failed, 180 failed some476 # 500: for fastmodels never failed for asac on slow, 120 failed, 180 failed some
477 session.run('/system/bin/disablesuspend.sh', timeout=240)477 session.run('/system/bin/disablesuspend.sh', timeout=500)
478478
479 def _enable_network(self):479 def _enable_network(self):
480 session = TesterCommandRunner(self, wait_for_rc=False)480 session = TesterCommandRunner(self, wait_for_rc=False)

Subscribers

People subscribed via source and target branches