webbrowser-app

Code review comment for lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_view

  1. webbrowser-app-bookmarks_view
  2. Merge into trunk
Revision history for this message
Olivier Tilloy (osomon) wrote :

In BookmarksView.qml and BookmarksViewWide.qml, there are references to 'browser' (calls to browser.openUrlInNewTab). This breaks encapsulation. Please replace this with a signal emission that will be connected to in Browser.qml.

review: Needs Fixing

« Back to merge proposal