Code review comment for lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_view

Revision history for this message
Ugo Riboni (uriboni) wrote :

Thanks for the fixes, but there is still a couple of issues that should be addressed:

1) Please make sure the header of the history and bookmarks pages is the same size. Check this screenshot to see the difference: http://i.imgur.com/2a5oeuu.png

2) The divider line in narrow screen mode for the bookmarks and history is in the wrong place (there is white space below the line), as you can see here: http://i.imgur.com/i38zcKK.png

3) Can you please make sure that you added unit tests for this feature: "The folders in the [narrow screen mode] bookmarks view should start all collapsed, instead of all open, unless no folders exist." ?

review: Needs Fixing

« Back to merge proposal