Code review comment for lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_view

Revision history for this message
Ugo Riboni (uriboni) wrote :

- I can not get any favicon to load, even for sites that I just visited and have a favicon. The "globe" icon is always shown instead

- Open two browsers windows side by side and in one open the bookmarks view and in the other the history view:
  The styles of the two are not consistent with each other. If necessary speak with design about this, but I would change the following things:
  - In widescreen mode:
    - Use the same font as the history items for bookmark items
    - Use the same font as the dates in the history view for folders
    - The bookmarks view header should have a separator
    - The folder list items should have a separator
  - In non-widescreen mode:
    - The bookmarks view has an header, the history doesn't. I would add one to the history.
    - The folders in the bookmarks view should probably start all collapsed instead of all open, unless no folders exist.

review: Needs Fixing

« Back to merge proposal