> A tiny remark on semantics:
>
> 943 + def ensure_new_tab_view_visible(self):
> 947 + def ensure_new_tab_view_eventually_hidden(self):
>
> Those two methods should be renamed:
>
> assert_new_tab_view_eventually_visible()
> assert_new_tab_view_eventually_hidden()
>
> Methods that start with "ensure_" actually perform some actions to ensure that
> the result is achieved, as opposed to methods that start with "assert_" that
> merely wait until the condition is verified.
> A tiny remark on semantics: new_tab_ view_visible( self): new_tab_ view_eventually _hidden( self): new_tab_ view_eventually _visible( ) new_tab_ view_eventually _hidden( )
>
> 943 + def ensure_
> 947 + def ensure_
>
> Those two methods should be renamed:
>
> assert_
> assert_
>
> Methods that start with "ensure_" actually perform some actions to ensure that
> the result is achieved, as opposed to methods that start with "assert_" that
> merely wait until the condition is verified.
Fixed on revision 581