Code review comment for lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_top_sites
Revision history for this message
| Olivier Tilloy (osomon) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
209 + property int bookmarksCountL
210 + property bool seeMoreBookmark
It looks like those two properties don’t need to be exposed publicly, as they’re not being used anywhere outside the component. Can they be made private, by moving them to a QtObject instance with id 'private'?