Code review comment for lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_top_sites

Revision history for this message
Olivier Tilloy (osomon) wrote :

114 + onUrlChanged: {
119 + function loadNewTabView() {
125 + function unloadNewTabView() {

There is a more declarative way of writing this: have a Component that contains a NewTabView inside the loader, and set the 'sourceComponent' property of the loader to "parent.url ? undefined : newTabViewComponent".

« Back to merge proposal