Code review comment for lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_top_sites
Revision history for this message
| Arthur Mello (artmello) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> As already discussed, in the current implementation TopSitesSheet is always
> instantiated. Instead, it should be loaded on demand (encapsulating it in a
> Component, or using a Loader), only when the user requests a new tab. It
> should probably be destroyed as soon as the URL of the current webview becomes
> non empty, and instantiated again when switching to a webview with an empty
> URL.
Fixed on revision 571