Code review comment for lp:~artmello/webbrowser-app/webbrowser-app-bookmarks_top_sites

Revision history for this message
Arthur Mello (artmello) wrote :

> Can you back out the changes to the bookmarks model? Ugo has been working on a
> branch to add the timestamp separately (see https://code.launchpad.net
> /~phablet-team/webbrowser-app/webbrowser-app-bookmark-
> timestamp/+merge/224117). Additionally, I don’t think we’ll need
> BookmarksChronologicalModel as we will ensure the original BookmarksModel is
> always sorted by creation date (AFAIK there is no use case for sorting them
> otherwise).
>
> So until we merge Ugo’s branch (which needs some rework that I’ll probably
> take on), bookmarks would not be ordered by creation date in the new tab page,
> but that shouldn’t be too bad for a start.

Fixed on revision 565

« Back to merge proposal