Merge lp:~artmello/gallery-app/gallery-app-remove_sdcard_during_load into lp:gallery-app

Proposed by Arthur Mello
Status: Merged
Merged at revision: 1135
Proposed branch: lp:~artmello/gallery-app/gallery-app-remove_sdcard_during_load
Merge into: lp:gallery-app
Diff against target: 50 lines (+18/-0)
3 files modified
src/media-object-factory.cpp (+2/-0)
src/media/media-collection.cpp (+15/-0)
src/media/media-collection.h (+1/-0)
To merge this branch: bzr merge lp:~artmello/gallery-app/gallery-app-remove_sdcard_during_load
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+247616@code.launchpad.net

Commit message

Do not create objects if the file was removed from the time the create was requested and when it was started

Description of the change

Do not create objects if the file was removed from the time the create was requested and when it was started

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/media-object-factory.cpp'
--- src/media-object-factory.cpp 2015-01-25 20:09:25 +0000
+++ src/media-object-factory.cpp 2015-01-26 16:47:14 +0000
@@ -177,6 +177,8 @@
177 Q_ASSERT(m_mediaTable);177 Q_ASSERT(m_mediaTable);
178178
179 QFileInfo file(path);179 QFileInfo file(path);
180 if(!file.exists())
181 return;
180182
181 clearMetadata();183 clearMetadata();
182184
183185
=== modified file 'src/media/media-collection.cpp'
--- src/media/media-collection.cpp 2015-01-23 20:00:50 +0000
+++ src/media/media-collection.cpp 2015-01-26 16:47:14 +0000
@@ -161,6 +161,21 @@
161/*!161/*!
162 * \reimp162 * \reimp
163 */163 */
164void MediaCollection::add(DataObject *object)
165{
166 MediaSource* media = qobject_cast<MediaSource*>(object);
167 if (media->file().exists()) {
168 m_idMap.insert(media->id(), media);
169 DataCollection::add(object);
170 } else {
171 m_mediaTable->remove(media->id());
172 media->deleteLater();
173 }
174}
175
176/*!
177+ * \reimp
178+ */
164void MediaCollection::addMany(const QSet<DataObject *> &objects)179void MediaCollection::addMany(const QSet<DataObject *> &objects)
165{180{
166 foreach (DataObject* data, objects) {181 foreach (DataObject* data, objects) {
167182
=== modified file 'src/media/media-collection.h'
--- src/media/media-collection.h 2015-01-23 20:00:50 +0000
+++ src/media/media-collection.h 2015-01-26 16:47:14 +0000
@@ -48,6 +48,7 @@
48 const MediaSource* mediaFromFileinfo(const QFileInfo &file) const;48 const MediaSource* mediaFromFileinfo(const QFileInfo &file) const;
49 bool containsFile(const QString& filename) const;49 bool containsFile(const QString& filename) const;
5050
51 virtual void add(DataObject* object);
51 virtual void addMany(const QSet<DataObject*>& objects);52 virtual void addMany(const QSet<DataObject*>& objects);
5253
53 void destroy(MediaSource *media, bool destroy_backing);54 void destroy(MediaSource *media, bool destroy_backing);

Subscribers

People subscribed via source and target branches