Code review comment for lp:~artmello/gallery-app/gallery-app-remove_photo_from_album

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

There are some mixed tab/spaces which cause errors and other pep8 issues

  1 album_view.py|10 col 1| F401 'os' imported but unused
  2 album_view.py|141 col 80| E501 line too long (83 > 79 characters)
  3 album_view.py|149 col 80| E501 line too long (84 > 79 characters)
  4 album_view.py|155 col 80| E501 line too long (84 > 79 characters)
  5 album_view.py|157 col 80| E501 line too long (82 > 79 characters)
  6 album_view.py|180 col 5| E101 indentation contains mixed spaces and tabs
  7 album_view.py|180 col 5| W191 indentation contains tabs
  8 album_view.py|185 col 5| E101 indentation contains mixed spaces and tabs
  9 album_view.py|185 col 5| W191 indentation contains tabs
 10 album_view.py|190 col 5| E101 indentation contains mixed spaces and tabs
 11 album_view.py|190 col 5| W191 indentation contains tabs
 12 album_view.py|195 col 5| E101 indentation contains mixed spaces and tabs
 13 album_view.py|195 col 5| W191 indentation contains tabs
 14 album_view.py|200 col 5| E101 indentation contains mixed spaces and tabs
 15 album_view.py|200 col 5| W191 indentation contains tabs
 16 album_view.py|205 col 5| E101 indentation contains mixed spaces and tabs
 17 album_view.py|205 col 5| W191 indentation contains tabs
 18 album_view.py|215 col 80| E501 line too long (87 > 79 characters)

tests/test_album_view.py:11:1: F401 'Is' imported but unused
tests/test_album_view.py:129:13: E128 continuation line under-indented for visual indent
tests/test_album_view.py:149:13: E128 continuation line under-indented for visual indent
tests/test_album_view.py:171:13: E128 continuation line under-indented for visual indent

I've also left an inline code comment for an additional assert

review: Needs Fixing

« Back to merge proposal