Code review comment for lp:~artmello/gallery-app/gallery-app-fix_toolbar_device

Revision history for this message
Olivier Tilloy (osomon) wrote :

This reverts a change that was introduced at revision 919 (3 months ago) and that was part of a bigger set of changes entitled "click support". There might have been a good reason for the gallery app to be run fullscreen on devices, so before reverting this, I would like to understand why it was like this in the first place.

Also, if we go ahead with this change, the comment a couple of lines above needs to be updated, as it says "run fullscreen if […] on a device".

Finally, a suggestion that you might want to try out: could it be that the problem happens because the view is first shown and then made fullscreen (thus messing the coordinates)? If that was the case, then I believe calling m_view->showFullScreen() might work around the issue.

review: Needs Fixing

« Back to merge proposal