Merge lp:~artmello/gallery-app/gallery-app-fix_1613816 into lp:gallery-app

Proposed by Arthur Mello
Status: Merged
Approved by: Bill Filler
Approved revision: 1326
Merged at revision: 1327
Proposed branch: lp:~artmello/gallery-app/gallery-app-fix_1613816
Merge into: lp:gallery-app
Diff against target: 39 lines (+5/-11)
2 files modified
tests/autopilot/gallery_app/emulators/media_selector.py (+3/-9)
tests/autopilot/gallery_app/tests/test_events_view.py (+2/-2)
To merge this branch: bzr merge lp:~artmello/gallery-app/gallery-app-fix_1613816
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+303213@code.launchpad.net

Commit message

Fix how autopilot tests select media entries from Organic media view

Description of the change

Fix how autopilot tests select media entries from Organic media view

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:1326
https://jenkins.canonical.com/system-apps/job/lp-gallery-app-ci/11/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/1235
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/264
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1235
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1107
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1107
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1107
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1094/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1094/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1094/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1094/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1094/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1094/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1094/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1094/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1094
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1094/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-gallery-app-ci/11/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/gallery_app/emulators/media_selector.py'
--- tests/autopilot/gallery_app/emulators/media_selector.py 2016-02-12 21:53:45 +0000
+++ tests/autopilot/gallery_app/emulators/media_selector.py 2016-08-18 04:09:35 +0000
@@ -21,17 +21,11 @@
21 def get_second_photo(self):21 def get_second_photo(self):
22 """Return the second photo item"""22 """Return the second photo item"""
23 selector = self.get_media_selector()23 selector = self.get_media_selector()
24
25 # get the first row in the selector24 # get the first row in the selector
26 mediaRow = selector.wait_select_single(objectName="mediaSelectorList0")25 events = self.app.select_many('OrganicMediaList')
2726 photos = events[0].select_many( 'QQuickItem', objectName='eventPhoto')
28 # get the loader for the second item
29 thumbnailLoader = mediaRow.wait_select_single(
30 objectName="thumbnailLoader1")
31
32 # return the item itself27 # return the item itself
33 return thumbnailLoader.wait_select_single(objectName="eventPhoto",28 return photos[0]
34 thumbnailLoaded=True)
3529
36 def ensure_fully_open(self):30 def ensure_fully_open(self):
37 """Ensure media selector is fully open"""31 """Ensure media selector is fully open"""
3832
=== modified file 'tests/autopilot/gallery_app/tests/test_events_view.py'
--- tests/autopilot/gallery_app/tests/test_events_view.py 2016-03-07 20:20:03 +0000
+++ tests/autopilot/gallery_app/tests/test_events_view.py 2016-08-18 04:09:35 +0000
@@ -130,8 +130,8 @@
130 self.assertThat(lambda: exists(self.sample_jpg_files[3]),130 self.assertThat(lambda: exists(self.sample_jpg_files[3]),
131 Eventually(Equals(True)))131 Eventually(Equals(True)))
132 self.enable_select_mode()132 self.enable_select_mode()
133 self.events_view.select_photo(self.sample_jpg_files[2])133 self.events_view.select_photo(self.sample_jpg_files[2], 1)
134 self.events_view.select_photo(self.sample_jpg_files[3])134 self.events_view.select_photo(self.sample_jpg_files[3], 0)
135 self.main_view.get_header().click_action_button("shareButton")135 self.main_view.get_header().click_action_button("shareButton")
136 share_picker = self.events_view.get_share_peer_picker()136 share_picker = self.events_view.get_share_peer_picker()
137 self.assertThat(share_picker.visible, Eventually(Equals(True)))137 self.assertThat(share_picker.visible, Eventually(Equals(True)))

Subscribers

People subscribed via source and target branches