Merge lp:~artmello/gallery-app/gallery-app-create_album_after_confirm into lp:gallery-app

Proposed by Arthur Mello
Status: Merged
Approved by: Bill Filler
Approved revision: 1119
Merged at revision: 1119
Proposed branch: lp:~artmello/gallery-app/gallery-app-create_album_after_confirm
Merge into: lp:gallery-app
Diff against target: 25 lines (+3/-1)
2 files modified
rc/qml/AlbumEditor/AlbumEditor.qml (+3/-0)
rc/qml/AlbumsOverview.qml (+0/-1)
To merge this branch: bzr merge lp:~artmello/gallery-app/gallery-app-create_album_after_confirm
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+244371@code.launchpad.net

Commit message

Delay the adding of a new album until the editor is finished

Description of the change

Delay the adding of a new album until the editor is finished

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'rc/qml/AlbumEditor/AlbumEditor.qml'
--- rc/qml/AlbumEditor/AlbumEditor.qml 2014-10-17 07:40:40 +0000
+++ rc/qml/AlbumEditor/AlbumEditor.qml 2014-12-11 01:44:40 +0000
@@ -219,6 +219,9 @@
219 onHidden: {219 onHidden: {
220 if(album.newAlbum)220 if(album.newAlbum)
221 albumModel.destroyAlbum(album);221 albumModel.destroyAlbum(album);
222 else
223 albumCollectionModel.addOrphan(album);
224
222 overview.popPage();225 overview.popPage();
223 albumEditor.closeRequested(albumEditor.album, true);226 albumEditor.closeRequested(albumEditor.album, true);
224 }227 }
225228
=== modified file 'rc/qml/AlbumsOverview.qml'
--- rc/qml/AlbumsOverview.qml 2014-12-09 02:56:17 +0000
+++ rc/qml/AlbumsOverview.qml 2014-12-11 01:44:40 +0000
@@ -237,7 +237,6 @@
237 var album = albumCollectionModel.createOrphan();237 var album = albumCollectionModel.createOrphan();
238 album.title = i18n.tr("New Photo Album");238 album.title = i18n.tr("New Photo Album");
239 album.subtitle = i18n.tr("Subtitle");239 album.subtitle = i18n.tr("Subtitle");
240 albumCollectionModel.addOrphan(album);
241240
242 albumEditor.album = album;241 albumEditor.album = album;
243 overview.pushPage(albumEditor);242 overview.pushPage(albumEditor);

Subscribers

People subscribed via source and target branches