lpci

Code review comment for ~artivis/lpci:feature/ros-plugins

  1. Git
  2. lp:~artivis/lpci
  3. feature/ros-plugins
  4. Merge into main
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

Looks good with some minor comments!

As we have no merge bot activated for lpcraft, I think I need to merge the MP.

Just tell me when you think it is ready to be merged.

Note for myself:
- In a follow-up MP we should split the plugins and the tests into submodules.
- In a follow-up MP we should revisit the currently used exceptions.

review: Approve
Reply

« Back to merge proposal