Code review comment for lp:~arthur-she/lava-dashboard/fix-for-bug-1175597

Revision history for this message
Arthur She (arthur-she) wrote :

Stevan, do you mean, use
    equation = models.CharField(
            choices=(
                ('lte', '<='),
                ('eq', '=='),
                ('gte', '>=')),
            max_length=3, default='==')
instead of
    equation = models.CharField(
            choices=(
                ('<=', '<='),
                ('==', '=='),
                ('>=', '>=')),
            max_length=3, default='==')
in the class TestRunFilterAttribute

2013/6/5 Stevan Radaković <email address hidden>

> One additional comment, we can circumvent the equation map altogether, if
> the db values for equation field would be defined as 'lte', 'gte'.. to
> start with. In the frontend we keep the '<=', '>=' of course...
> --
>
> https://code.launchpad.net/~arthur-she/lava-dashboard/fix-for-bug-1175597/+merge/167494
> You are the owner of lp:~arthur-she/lava-dashboard/fix-for-bug-1175597.
>

« Back to merge proposal