Code review comment for lp:~artem-anufrij/noise/Bugfix-1318871

Revision history for this message
PerfectCarl (name-is-carl) wrote :

The feature is very neat!
I don't know what the UI team thinks about it, but I like it.

That being said, I have remarks.

General
-------

Why did you use the CoverImporter and not the CoverCache?

You have the image for the album, so you don't need to re execute all the complicated cover import process but just to add the image to the cover cache and causes the album list to refresh.

Besides exposing the (now public) cover_importer is not a good idea.
It is best to simply add a new public method that would use the private member.

Formatting
----------

There must be a space between the function name and parenthesis.
  my_function () ;

« Back to merge proposal