Merge lp:~artem-anufrij/audience/Bugfix-1297408 into lp:~audience-members/audience/trunk

Proposed by Artem Anufrij
Status: Merged
Approved by: Cody Garver
Approved revision: 425
Merged at revision: 425
Proposed branch: lp:~artem-anufrij/audience/Bugfix-1297408
Merge into: lp:~audience-members/audience/trunk
Diff against target: 47 lines (+5/-6)
1 file modified
src/Audience.vala (+5/-6)
To merge this branch: bzr merge lp:~artem-anufrij/audience/Bugfix-1297408
Reviewer Review Type Date Requested Status
PerfectCarl (community) Approve
Audience Members Pending
Review via email: mp+238790@code.launchpad.net

Commit message

Respect playback_wait setting

Description of the change

if "playback_wait" has been set, Audience doesn't starts automatically playback after:
- start Audience
- open a video file (doubleclick) in Files
- open a video in Audience (open file dialog)
- drag and drop

To post a comment you must log in.
Revision history for this message
PerfectCarl (name-is-carl) wrote :

The code is clean.

Assuming it does what it says on the tin, it's all good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Audience.vala'
--- src/Audience.vala 2014-10-05 05:04:18 +0000
+++ src/Audience.vala 2014-10-18 09:12:19 +0000
@@ -409,7 +409,7 @@
409409
410 if (d.run () == Gtk.ResponseType.OK) {410 if (d.run () == Gtk.ResponseType.OK) {
411 open_file (entry.text, true);411 open_file (entry.text, true);
412 video_player.playing = true;412 video_player.playing = !settings.playback_wait;
413 welcome.hide ();413 welcome.hide ();
414 clutter.show_all ();414 clutter.show_all ();
415 }415 }
@@ -672,7 +672,7 @@
672672
673 var root = volume.get_mount ().get_default_location ();673 var root = volume.get_mount ().get_default_location ();
674 open_file (root.get_uri (), true);674 open_file (root.get_uri (), true);
675 video_player.playing = true;675 video_player.playing = !settings.playback_wait;
676676
677 welcome.hide ();677 welcome.hide ();
678 clutter.show_all ();678 clutter.show_all ();
@@ -753,8 +753,7 @@
753 video_player.set_subtitle_uri (sub_uri);753 video_player.set_subtitle_uri (sub_uri);
754754
755 mainwindow.title = get_title (uri);755 mainwindow.title = get_title (uri);
756 if (!settings.playback_wait)756 video_player.playing = !settings.playback_wait;
757 video_player.playing = true;
758757
759 Gtk.RecentManager recent_manager = Gtk.RecentManager.get_default ();758 Gtk.RecentManager recent_manager = Gtk.RecentManager.get_default ();
760 recent_manager.add_item (uri);759 recent_manager.add_item (uri);
@@ -779,7 +778,7 @@
779 open_file (settings.current_video);778 open_file (settings.current_video);
780 video_player.playing = false;779 video_player.playing = false;
781 Idle.add (() => {video_player.progress = settings.last_stopped; return false;});780 Idle.add (() => {video_player.progress = settings.last_stopped; return false;});
782 video_player.playing = true;781 video_player.playing = !settings.playback_wait;
783 }782 }
784 }783 }
785 }784 }
@@ -819,4 +818,4 @@
819 var app = Audience.App.get_instance ();818 var app = Audience.App.get_instance ();
820819
821 app.run (args);820 app.run (args);
822}821}
823\ No newline at end of file822\ No newline at end of file

Subscribers

People subscribed via source and target branches